mirror of
https://github.com/gradle/actions.git
synced 2025-11-26 17:09:10 +08:00
Fix Develocity deprecation warnings triggered by init-scripts
This commit is contained in:
@@ -54,6 +54,8 @@ class BaseInitScriptTest extends Specification {
|
||||
File settingsFile
|
||||
File buildFile
|
||||
|
||||
boolean allowDevelocityDeprecationWarning = false
|
||||
|
||||
@TempDir
|
||||
File testProjectDir
|
||||
|
||||
@@ -200,14 +202,16 @@ task expectFailure {
|
||||
}
|
||||
|
||||
BuildResult run(List<String> args, String initScript, GradleVersion gradleVersion = GradleVersion.current(), List<String> jvmArgs = [], Map<String, String> envVars = [:]) {
|
||||
createRunner(initScript, args, gradleVersion, jvmArgs, envVars).build()
|
||||
def result = createRunner(args, initScript, gradleVersion, jvmArgs, envVars).build()
|
||||
assertNoDeprecationWarning(result)
|
||||
}
|
||||
|
||||
BuildResult runAndFail(List<String> args, String initScript, GradleVersion gradleVersion = GradleVersion.current(), List<String> jvmArgs = [], Map<String, String> envVars = [:]) {
|
||||
createRunner(initScript, args, gradleVersion, jvmArgs, envVars).buildAndFail()
|
||||
def result = createRunner(args, initScript, gradleVersion, jvmArgs, envVars).buildAndFail()
|
||||
assertNoDeprecationWarning(result)
|
||||
}
|
||||
|
||||
GradleRunner createRunner(String initScript, List<String> args, GradleVersion gradleVersion = GradleVersion.current(), List<String> jvmArgs = [], Map<String, String> envVars = [:]) {
|
||||
GradleRunner createRunner(List<String> args, String initScript, GradleVersion gradleVersion = GradleVersion.current(), List<String> jvmArgs = [], Map<String, String> envVars = [:]) {
|
||||
File initScriptsDir = new File(testProjectDir, "initScripts")
|
||||
args << '-I' << new File(initScriptsDir, initScript).absolutePath
|
||||
|
||||
@@ -236,6 +240,13 @@ task expectFailure {
|
||||
}
|
||||
}
|
||||
|
||||
BuildResult assertNoDeprecationWarning(BuildResult result) {
|
||||
if (!allowDevelocityDeprecationWarning) {
|
||||
assert !result.output.contains("WARNING: The following functionality has been deprecated")
|
||||
}
|
||||
return result
|
||||
}
|
||||
|
||||
static final class TestGradleVersion {
|
||||
|
||||
final GradleVersion gradleVersion
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
package com.gradle.gradlebuildaction
|
||||
|
||||
import groovy.json.JsonSlurper
|
||||
import org.gradle.util.GradleVersion
|
||||
|
||||
import static org.junit.Assume.assumeTrue
|
||||
|
||||
@@ -198,7 +199,8 @@ class TestBuildResultRecorder extends BaseInitScriptTest {
|
||||
}
|
||||
}
|
||||
""" + settingsFile.text
|
||||
|
||||
|
||||
allowDevelocityDeprecationWarning = true
|
||||
run(testGradleVersion.gradleVersion)
|
||||
|
||||
then:
|
||||
|
||||
@@ -134,6 +134,10 @@ class TestDevelocityInjection extends BaseInitScriptTest {
|
||||
declareDevelocityPluginApplication(testGradleVersion.gradleVersion)
|
||||
|
||||
when:
|
||||
// Init-script emits deprecation warnings when CCUD plugin is applied on Gradle 5.6.4
|
||||
if (testGradleVersion.gradleVersion.version == "5.6.4") {
|
||||
allowDevelocityDeprecationWarning = true
|
||||
}
|
||||
def result = run(testGradleVersion, testConfig().withCCUDPlugin())
|
||||
|
||||
then:
|
||||
|
||||
Reference in New Issue
Block a user